Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split SBT into a submodule #177

Open
luizirber opened this issue Apr 17, 2017 · 4 comments
Open

Split SBT into a submodule #177

luizirber opened this issue Apr 17, 2017 · 4 comments
Labels
5.0 issues to address for a 5.0 release help wanted sbt
Milestone

Comments

@luizirber
Copy link
Member

SBT is growing, and is now spread in three different places:

  • sourmash_lib.sbt: the standard SBT implementation, using bloom filters for internal nodes and leaves.
  • sourmash_lib.sbtmh: the MinHash extensions, with a leaf node for MinHashes and a search function.
  • sourmash_lib.sbt_storage: Different storage backends for SBTs

The proposal is to create a new sbt submodule in sourmash, and move the separate files into a new structure:

  • sourmash_lib.sbt, also containing possible subcommand options for SBTs
  • sourmash_lib.sbt.mh
  • sourmash_lib.sbt.storage
@phiweger
Copy link

This would be neat. Especially if the API allowed easy experimentation with arbitrary sequences, e.g. DNA, signatures etc.

@ctb
Copy link
Contributor

ctb commented Apr 19, 2017 via email

@ctb
Copy link
Contributor

ctb commented May 19, 2017

note that the command line API is heading in the other direction with #240 - 'sbt_search' -> 'search', etc.

@ctb
Copy link
Contributor

ctb commented Mar 9, 2018

Yes, please.

@luizirber luizirber added this to the 4.0 milestone Jan 15, 2020
@luizirber luizirber added the 4.0 issues to address for a 4.0 release label Jan 15, 2020
@ctb ctb added 5.0 issues to address for a 5.0 release and removed 4.0 issues to address for a 4.0 release labels Feb 6, 2021
@luizirber luizirber modified the milestones: 4.0, 5.0 Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 issues to address for a 5.0 release help wanted sbt
Projects
None yet
Development

No branches or pull requests

3 participants