You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #1936, I'm adding tests for basic features of the Index class, and RevIndex doesn't pass them. (RevIndex is the rust-based reverse index added in #1238.)
When uncommenting the build_revindex part of the index_obj fixture in tests/test_index_protocols.py from #1936, we see that select with the wrong ksize doesn't work:
self = <sourmash.index.revindex.RevIndex object at 0x7fd5d02b8cd0>, ksize = 21
moltype = None, kwargs = {}
def select(self, ksize=None, moltype=None, **kwargs):
if self.template:
if ksize:
> self.template.ksize = ksize
E AttributeError: can't set attribute
src/sourmash/index/revindex.py:152: AttributeError
We might also want to do more specific tests of RevIndex in tests/test_index.py and/or add docs on its value, API, and intended use.
The text was updated successfully, but these errors were encountered:
In #1936, I'm adding tests for basic features of the
Index
class, andRevIndex
doesn't pass them. (RevIndex
is the rust-based reverse index added in #1238.)When uncommenting the
build_revindex
part of theindex_obj
fixture intests/test_index_protocols.py
from #1936, we see thatselect
with the wrong ksize doesn't work:We might also want to do more specific tests of
RevIndex
intests/test_index.py
and/or add docs on its value, API, and intended use.The text was updated successfully, but these errors were encountered: