New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm sketching sets `null` filename and missing `name`. #3405

Open

mr-eyes opened this issue Nov 20, 2024 · 0 comments

Member

mr-eyes commented Nov 20, 2024

From slack:

@mr-eyes: Can someone confirm with me that https://ebi-metagenomics.github.io/mgnify-sourmash-component/ does not export the "name" field in signature before I open an issue or PR? signatures exported from mgnify fails to load in sourmash.

@luizirber:
for branchwater.sourmash.bio it is not an issue because it only cares about the hashes.
likely fixable by setting filename here:

sourmash/src/core/src/wasm.rs

Line 152 in 94d37f9

using https://rustwasm.github.io/wasm-bindgen/api/web_sys/struct.File.html#method.name
but better if actually setting the name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment