Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exception handling for JSON::ParserError #155

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Add exception handling for JSON::ParserError #155

merged 1 commit into from
Nov 16, 2017

Conversation

ton31337
Copy link
Contributor

@ton31337 ton31337 commented Dec 7, 2016 •
edited
Loading

Add exception handling for JSON::ParserError. Without this exception handling, error is returned on updating resources:

           Error executing action `update` on resource 'grafana_datasource[prometheus]'
           ================================================================================

           JSON::ParserError
           -----------------
           784: unexpected token at '<*api.NormalResponse Value>'

After this, everything is fine, all resources including grafana_datasource, grafana_user, grafana_dashboard, grafana_organization are working properly as expected.

In addition replacing proper property name for reporting: #156

@ton31337 ton31337 force-pushed the Fix/add_json_parse_exception branch 2 times, most recently from 5bb18a2 to 8a4d03c Compare December 7, 2016 17:20
scopenco
scopenco suggested changes Nov 15, 2017
View reviewed changes
Copy link
Contributor

@scopenco scopenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for PR! Please leave only libraries/organization_api.rb changes and rebase PR.

@ton31337 ton31337 force-pushed the Fix/add_json_parse_exception branch 2 times, most recently from b93fb0d to 54e4d48 Compare November 16, 2017 06:13
@ton31337 ton31337 force-pushed the Fix/add_json_parse_exception branch from 54e4d48 to 19ac2ff Compare November 16, 2017 06:43
@ton31337
Copy link
Contributor Author

👍

@scopenco scopenco merged commit ee72909 into sous-chefs:master Nov 16, 2017
@ton31337 ton31337 deleted the Fix/add_json_parse_exception branch November 16, 2017 06:47
@lock
Copy link

lock bot commented Nov 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scopenco scopenco scopenco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ton31337 @scopenco