Updating consul version does not restart consul

[joerocklin]

Not sure if this is a bug for poise, libartifact, or the use of them both here. What I'm seeing is: when running the cookbooks and doing an upgrade from 0.5.2 -> 0.6.0 (binary install), the binary gets updated but the service isn't restarted. It looks like there's a subscription on config file changes, but there's no config file change in this process!

I looked to see if there was a convenient way to subscribe/notify on a binary update, but I'm not very familiar with poise or libartifact, and the fact that it's updating the binary inside an LWRP complicates things a bit.

[Ginja]

I noticed this as well.

+1

[johnbellone]

I have tracked this down with some of our other cookbooks. I'm going to test a fix.

[kamaradclimber]

hello @johnbellone,

do you need help for a fix on this issue?

In the meantime I have added a simple restart in my wrapper cookbook:

log 'Trigger consul restart because of version update' do
  notifies :restart, "consul_service[#{node['consul']['service_name']}]"
  only_if do
  cmd = case node['platform']
          when 'windows'
            Mixlib::ShellOut.new('"C:\Program Files\consul\consul.exe" info')
          else
            Mixlib::ShellOut.new("consul info")
          end

    cmd.run_command
    cmd.error!
    version = cmd.stdout.lines.
      select { |l| l =~ /version/ && !(l =~ /go/) }.
      first.gsub(/.* = ([0-9.]+)$/, '\1').strip
    version != node['consul']['version']
  end 
end

[johnbellone]

Some help would definitely be appreciated!

[gdavison]

I've noticed recently that, at least on Windows, it's not restarting on config file changes, either. Not sure if this is related.

Steps:

1. Install
2. Consul starts
3. Tweak config attributes
4. Re-run chef
5. Doesn't restart

[scalp42]

Any chance to make the restart optional please?

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.