Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay upstart started event until Consul is ready #318

Closed
gdavison opened this issue May 25, 2016 · 2 comments · Fixed by #320
Closed

Delay upstart started event until Consul is ready #318

gdavison opened this issue May 25, 2016 · 2 comments · Fixed by #320

Comments

@gdavison
Copy link
Contributor

gdavison commented May 25, 2016

When Consul is started with upstart, upstart emits a started event once the service is launched, but it takes several seconds before it is ready to serve requests. If you have other services, such as consul-replicate, which depend on Consul, they can thrash before Consul is ready.

A stanza can be added to the Consul upstart config that would delay emitting the event until it is ready, or a similar stanza can be added to the upstart configs of any services that depend on Consul. See http://upstart.ubuntu.com/cookbook/#post-start

I think it would make sense to add it to this cookbook, so that it's handled in one place, and also because it signals that Consul is truly ready.

Thoughts?

@johnbellone
Copy link
Contributor

This makes sense to me. It should be added as a separate template and we can add the override in service options (consul service resource).

@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants