Question - Are custom configs required everywhere?

[spuder]

I noticed the following comment

These are the default settings. Most of the time, you want to override

the configuration attribute below. If you do override the defaults, you

must supply ALL needed defaults, and don't use nil as a value in the hash.

https://github.com/elastic/cookbook-elasticsearch/blob/2.0.0_wip/libraries/resource_configure.rb#L76-L78

Does this mean that you need to supply all possible configs?

In other words, here only the cluster.name is set. Is that bad?

elasticsearch_configure 'nd-elasticsearch' do
  allocated_memory '123m'
  thread_stack_size '512k'

  gc_settings <<-CONFIG
                -XX:+UseParNewGC
                -XX:+UseConcMarkSweepGC
                -XX:CMSInitiatingOccupancyFraction=75
                -XX:+UseCMSInitiatingOccupancyOnly
                -XX:+HeapDumpOnOutOfMemoryError
                -XX:+PrintGCDetails
              CONFIG
  configuration ({
    'cluster.name' => node['nd-elasticsearch']['config']['cluster_name']
    })
  action :manage
end

[spuder]

As a side note, I find that the default values listed in the comments, aren't correct (atleast if using :package 📦 installation)

https://github.com/elastic/cookbook-elasticsearch/blob/2.0.0_wip/libraries/resource_configure.rb#L85-L87

[martinb3]

That note is specifically on attribute(:default_configuration... (not the configuration attribute that you're asking about setting). It's saying that those defaults are merged with values you supply in attribute(:configuration.... If you override the entire default hash, you get zero default settings. If you override the configuration hash, you get those merged in on top of the defaults.

[martinb3]

As a side note, I find that the default values listed in the comments, aren't correct (atleast if using :package 📦 installation)

You can see the default values that will be used here:
https://github.com/elastic/cookbook-elasticsearch/blob/2.0.0_wip/libraries/resource_configure.rb#L12-L40

Before packages existed, the default values were for the tarball (non-packaged) install. Some of the comments definitely need to be updated, but the code itself is accurate. Thank you for pointing that out -- I'll fix those comments before release.

[spuder]

Thanks for the info. As another side note, the correct paths in the packages were revealed when I commented out the lines in the recipe.

         +path.conf: /etc/elasticsearch
         +path.data: /usr/share/elasticsearch
         +path.logs: /var/log/elasticsearch

[martinb3]

@spuder I'm not sure what you mean by your last update. When you commented out what lines and in which recipe? I only see links to libraries and an elasticsearch_configure recipe snippet that didn't contain any paths to start with.