You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was using this cookbook as a reference for one I am writing and while just reading the source code I believe I happened across a latent bug in the handling of adding the git installation path to the Windows PATH
not_if { ENV['PATH'] =~ /#{GIT_PATH}/ }
and NOT not_if { ENV['PATH'] =~ /GIT_PATH/ }
as you don't want to be looking for the string literal "GIT_PATH" but the value of that variable, interpolated.
🥞 Cookbook version
11.1 but expect that this exists in far earlier versions.
👩🍳 Chef-Infra Version
N/A
🎩 Platform details
N/A
Steps To Reproduce
N/A
🚓 Expected behavior
N/A
➕ Additional context
N/A
The text was updated successfully, but these errors were encountered:
👻 Brief Description
I was using this cookbook as a reference for one I am writing and while just reading the source code I believe I happened across a latent bug in the handling of adding the git installation path to the Windows PATH
I am 99.99% sure that at https://github.com/sous-chefs/git/blob/main/resources/client_windows.rb#L38 the code should be:
not_if { ENV['PATH'] =~ /#{GIT_PATH}/ }
and NOT
not_if { ENV['PATH'] =~ /GIT_PATH/ }
as you don't want to be looking for the string literal "GIT_PATH" but the value of that variable, interpolated.
🥞 Cookbook version
11.1 but expect that this exists in far earlier versions.
👩🍳 Chef-Infra Version
N/A
🎩 Platform details
N/A
Steps To Reproduce
N/A
🚓 Expected behavior
N/A
➕ Additional context
N/A
The text was updated successfully, but these errors were encountered: