Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basepackages: FF pagination calculation for filtered condition is wrong #509

Closed
oyeaussie opened this issue Jul 6, 2024 · 0 comments
Closed
Assignees
Labels
bug Something is not working P3 I will get to this in a week or a month, bribe me to prioritise
Milestone

Comments

@oyeaussie
Copy link
Contributor

$paginationCounters['filtered_items'] = $this->modelToUse::count($this->filterConditions);

For DB, we have a method count where we can pass args $this->filterConditions, which will count as per the conditions we have provided. For FF this is missing.

######## Issue imported from Gitea ########

Details

Gitea Issue ID : 578
State : open
Created : 2024-06-14T22:25:16+10:00

Issue Description

$paginationCounters['filtered_items'] = $this->modelToUse::count($this->filterConditions);

For DB, we have a method count where we can pass args $this->filterConditions, which will count as per the conditions we have provided. For FF this is missing.

Timeline

Label : Added bug on 2024-06-14T22:25:16+10:00.
Label : Added P3 on 2024-06-14T22:25:16+10:00.
Milestone : Added 0.0.0-rc.5 on 2024-06-14T23:39:50+10:00.
Label : Added CanClose on 2024-06-15T00:10:53+10:00.
Commit Reference: !578 - Added criteria to count function

@oyeaussie oyeaussie added bug Something is not working CanClose Can Close, right before release P3 I will get to this in a week or a month, bribe me to prioritise labels Jul 6, 2024
@oyeaussie oyeaussie added this to the 0.0.0-rc.5 milestone Jul 6, 2024
@oyeaussie oyeaussie self-assigned this Jul 6, 2024
@oyeaussie oyeaussie removed the CanClose Can Close, right before release label Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working P3 I will get to this in a week or a month, bribe me to prioritise
Projects
None yet
Development

No branches or pull requests

1 participant