Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Animations in CEM variants don't work if base model doesn't exist #7859

Open
magmamir opened this issue Jan 10, 2025 · 2 comments
Open

Comments

@magmamir
Copy link

Description of Issue

CEM variants (e.g., iron_golem2.jem) don't get animations if the base model (e.g., iron_golem.jem) does not exist. If the base model exists, animations in the variant models work properly. Animations in the base model always function. The base model doesn't need to have animations itself to enable animations in the variant models. This issue doesn't exist in ETF+EMF mods.

Steps to Reproduce

  1. Download of_bug_test.zip resourcepack and activate it.
  2. Create a custom mob with /summon minecraft:iron_golem ~ ~ ~ {NoAI:1b,HandItems:[{},{id:"minecraft:jigsaw",count:1,components:{"minecraft:custom_data":{mmdp:{deformation:{mob:{blastling:{model:2b}}}}}}}]} command
  3. Observe that it has no custom animation (hands are not moving)
    2025-01-10_03 16 12
  4. Download of_bug_test_below.zip resourcepack (which is basically just a vanilla iron_golem.jem placed in optifine/cem folder) and activate it by placing below the of_bug_test.zip. Alternatively you can place any iron_golem.jem file to optifine/cem folder of the of_bug_test.zip.
  5. Observe that the mob now have animations (hands are moving)
    2025-01-10_03 15 45

Affected Versions

  • OptiFine HD U J1 1.21.1
  • OptiFine HD U J2 1.21.3
  • OptiFine HD U J3 pre9 1.21.4

Maybe others

Installation Method

  • Standalone versions
@ZenithRogue
Copy link
Collaborator

Honestly never even tried doing this, figuring nothing would happen. My recommendation is to place an iron_golem.jem file in the CEM folder containing only the following

{}

@magmamir
Copy link
Author

I checked now, and it seems that {} doesn't work. The behavior of iron_golem.jem containing only brackets is identical to not having the iron_golem.jem at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants