Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Satellite page styling issues in smaller size device #44

Closed
minhhang107 opened this issue Oct 6, 2021 · 3 comments · Fixed by #45
Closed

Satellite page styling issues in smaller size device #44

minhhang107 opened this issue Oct 6, 2021 · 3 comments · Fixed by #45
Assignees
@minhhang107

Comments

@minhhang107
Copy link
Contributor

Describe the bug
Satellite page has some styling issues when viewed on phone/tablet screens:

  1. Satellite image is covering other components (covering Submit button on phone screen, covering Search bar on tablet screen) (see screenshot 1)
  2. When there's no result for search, error texts are not centered (see screenshot 2)
  3. When there's no result for search, error text shows "We don't know about the planet.." (see screenshot 2)

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://space-voyager.vercel.app/satellite on a mobile device
  2. Search for an invalid satellite (eg: abc)
  3. See error

Expected behavior

  1. Satellite image should not cover any other components
  2. When there's no result for search, error texts should be centered
  3. When there's no result for search, error text should show "We don't know about the satellite.."

Screenshots

voyager2

voyager1
@minhhang107
Copy link
Contributor Author

I would like to work on this issue. Can I be assigned?

@mohittk
Copy link
Member

mohittk commented Oct 6, 2021

Describe the bug Satellite page has some styling issues when viewed on phone/tablet screens:

  1. Satellite image is covering other components (covering Submit button on phone screen, covering Search bar on tablet screen) (see screenshot 1)
  2. When there's no result for search, error texts are not centered (see screenshot 2)
  3. When there's no result for search, error text shows "We don't know about the planet.." (see screenshot 2)

To Reproduce Steps to reproduce the behavior:

  1. Go to space-voyager.vercel.app/satellite on a mobile device
  2. Search for an invalid satellite (eg: abc)
  3. See error

Expected behavior

  1. Satellite image should not cover any other components
  2. When there's no result for search, error texts should be centered
  3. When there's no result for search, error text should show "We don't know about the satellite.."

Screenshots

voyager2

voyager1

Ohh Yea! I observed the issues very well. Glad that you saw that so closely. Can you fix them? @minhhang107

@mohittk
Copy link
Member

mohittk commented Oct 6, 2021

I would like to work on this issue. Can I be assigned?

Yea! sure.
All the best.

@minhhang107 minhhang107 mentioned this issue Oct 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@minhhang107 minhhang107

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix styling for Satellite page on smaller devices minhhang107/space-voyager
2 participants
@minhhang107 @mohittk