Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headphones will no longer give the alternative activated sprite #31755

Open
bruhmogus opened this issue Sep 2, 2024 · 5 comments
Open

Headphones will no longer give the alternative activated sprite #31755

bruhmogus opened this issue Sep 2, 2024 · 5 comments
Labels
D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: Bugfix Type: Bugs and/or bugfixes

Comments

@bruhmogus
Copy link

Description

Regardless of activated or deactivated, headphones no longer have the little notes.

Reproduction
Turn on headphones
Wear them
Cry

Screenshots
20240902094830_1

Additional context
This physically hurts me.

@github-actions github-actions bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Sep 2, 2024
@Boaz1111
Copy link
Contributor

Boaz1111 commented Sep 2, 2024

@slarticodefast you wanted more instances of broken itemtoggle, aye?

@Everturning
Copy link

Also wanted to mention that for some reason I can't put them on, but that may be worth its own issue

@slarticodefast
Copy link
Member

you wanted more instances of broken itemtoggle, aye?

I already fixed all those that had toggleable pointlights.. They were missing the new ItemTogglePointLightComponent introduced in #31312. This seems to be a different bug, but may be caused by that PR as well.

Also affected is the telescopic shield and possibly other items with toggleable visuals.

@slarticodefast slarticodefast added T: Bugfix Type: Bugs and/or bugfixes P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. D3: Low Difficulty: Some codebase knowledge required. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Sep 2, 2024
@Azzizi
Copy link

Azzizi commented Oct 29, 2024

Looking into this now to dip my toes into contribution; headphones are set up with

type: ToggleableLightVisuals
    spriteLayer: enum.ToggleVisuals.Layer
    clothingVisuals:
      neck:
      - state: on-equipped-NECK

in Clothing/Neck/misc.yml

Looking at other items with this type, this appears to be incorrect syntax and should be a simple correction-- I'm working on hammering it out now.

Edit: My initial thought isn't 100% on target but I'm pretty sure this is still an issue in the YAML for the headphones

@ArtisticRoomba
Copy link
Contributor

Tested, issue is caused by #31312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants