feat: generalize sum_expr in GroupByExpr
#36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iajoiner
force-pushed
the
feat/sum-gen
branch
5 times, most recently
from
29c6b02 to
b3ffe28
Compare
There was a problem hiding this comment.
Looks good. I believe changing the following should fix the failing tests
sxt-proof-of-sql/crates/proof-of-sql/src/sql/ast/aggregate_expr.rs
Lines 32 to 33 in 24b3592
It should be
fn count(&self, builder: &mut CountBuilder) -> Result<(), ProofError> {
self.expr.count(builder)
iajoiner
force-pushed
the
feat/sum-gen
branch
2 times, most recently
from
3c6e43c to
de436f9
Compare
iajoiner
force-pushed
the
feat/sum-gen
branch
3 times, most recently
from
e48f938 to
a819735
Compare
JayWhite2357
previously approved these changes
Jul 1, 2024
- fix bug in `AggregateExpr`
JayWhite2357
approved these changes
Jul 1, 2024
|
🎉 This PR is included in version 0.3.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR generalizes
GroupByExprby relaxing the requirement ofexprinSUM(expr)to arbitraryProvableExprPlanoutside aggregation.What changes are included in this PR?
Generalize
sum_exprinGroupByExprAre these changes tested?
Old tests all pass. We need to get new ones with nontrivial
sum_exprto pass as well.