Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlobalStateService and Reward stale APIs #163

Closed
brusherru opened this issue Jun 13, 2022 · 2 comments
Closed

GlobalStateService and Reward stale APIs #163

brusherru opened this issue Jun 13, 2022 · 2 comments
Labels
breaking change may break existing API builds and require implementation changes

Comments

@brusherru
Copy link
Member

The implementation of a few API endpoints and the Reward message type has been changed:
spacemeshos/go-spacemesh@697adda

So this repo needs an update to represent an actual API:

  • GlobalStateService.SmesherRewardStream and GlobalStateService.SmesherDataQuery are deprecated: they throws an exception "UNIMPLEMENTED DEPRECATED". So let's remove them from proto files.
  • Reward type (that returned within GlobalStateService.AccountDataQuery/Stream endpoints) has no more SmesherID field

Changes not released within v0.2.16-beta.0 are out of scope.

@countvonzero am I missing something else?

@brusherru brusherru added the breaking change may break existing API builds and require implementation changes label Jun 13, 2022
@lrettig
Copy link
Member

lrettig commented Jun 14, 2022

See also: spacemeshos/go-spacemesh#3257

@lrettig
Copy link
Member

lrettig commented Jun 15, 2022

As discussed in the linked issue/go-spacemesh repo discussion, these changes are not urgent, but it would be good to add new endpoint(s) to stream and/or query rewards from a given smesher, since the node does have this data (but it's not persisted to the mesh, not part of the protocol, and it's ephemeral since it lives in proposals and cannot be reconstructed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change may break existing API builds and require implementation changes
Projects
None yet
Development

No branches or pull requests

2 participants