-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: swarm config params #20
Comments
urfave/cli should load everything pretty smooth even from config files. though it has an open issue about parsing uint(64) and duration types, maybe we should use another toml parser (probably the one used by cli anyway) ? |
i think we should go w the cli parser for now and cast from ints. We should also decide toml vs. yaml and provide some demo config file. for duration i guess we can receive inputs in float or int rperesntijg secs and cast to duration. |
I discovered that to use the cli parsing feature flag names must be single names |
Perhaps parsing the config file ourselves as you suggest and just updating matched flag values is the way to go as it looks like the cli bug is open for almost a year. |
Done on #69 |
Feature description
Make all swarm config values command-line and config-file modifiable. Look at
SwarmConfigValues
- right now the values are hard-coded.Reasons for adding this feature
This feature will allow us to more easily test swarm features.
The text was updated successfully, but these errors were encountered: