Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the redundant space for kubectl symbol (iTerm2) #1205

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

Runrioter
Copy link
Member

Description

It is a bug from iTerm2 (and iOS terminal app)

iTerm2 fix this bug.(Since iTerm2 3.5.0beta7). Refer to

Also see #432

@netlify
Copy link

netlify bot commented Sep 19, 2022

Deploy Preview for spaceship-prompt ready!

Name Link
🔨 Latest commit cf9a89b
🔍 Latest deploy log https://app.netlify.com/sites/spaceship-prompt/deploys/63286f2d0a70c400090959fb
😎 Deploy Preview https://deploy-preview-1205--spaceship-prompt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Runrioter Runrioter self-assigned this Sep 19, 2022
@Runrioter Runrioter added the improvement A PR that make small changes for improving UX, performance, readability, etc label Sep 19, 2022
@denysdovhan denysdovhan merged commit 8ddbc81 into spaceship-prompt:master Sep 19, 2022
@denysdovhan
Copy link
Member

hey @Runrioter this seems like a fix not feature, i've changed the commit type

github-actions bot pushed a commit that referenced this pull request Sep 19, 2022
## [4.3.1](v4.3.0...v4.3.1) (2022-09-19)

### Bug Fixes

* Delete the redundant space for kubectl symbol (iTerm2) ([#1205](#1205)) ([8ddbc81](8ddbc81))
@denysdovhan
Copy link
Member

🎉 This PR is included in version 4.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@denysdovhan denysdovhan added the released Released issues and PRs label Sep 19, 2022
@Runrioter
Copy link
Member Author

@denysdovhan Sorry, it is a fix. 👍

@Runrioter Runrioter added bug Bug related to code base, behavior, displaying, etc. and removed improvement A PR that make small changes for improving UX, performance, readability, etc labels Sep 19, 2022
@Runrioter Runrioter deleted the delete-space branch September 19, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug related to code base, behavior, displaying, etc. released Released issues and PRs
Development

Successfully merging this pull request may close these issues.

2 participants