Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subset Edit Plugin: Implement live-updating #1565

Open
pllim opened this issue Aug 12, 2022 · 0 comments
Open

Subset Edit Plugin: Implement live-updating #1565

pllim opened this issue Aug 12, 2022 · 0 comments
Labels
feature Feature request plugin Label for plugins common to multiple configurations

Comments

@pllim
Copy link
Contributor

pllim commented Aug 12, 2022

This is a follow-up of #1427 . If we decided live-updating is no longer needed, then we can just archive this.

@duytnguyendtn and @kecnry both wanted live-updates. Several different ways proposed: Up/down arrows, tab, enter, when lost focus.

@pllim prefers not to live-update at all unless we determine that performance will not be impacted when we stress-test the feature. See #1427 (comment)

@camipacifici said the following at #1427 (comment) :

  • I would not want the live update to kick in when I start modifying the value. It would be nice to have it when I click the arrows, but it is useful really only for Imviz where a jump of "1" is ok. A jump of "1" in Specviz is completely useless because it goes to a completely different region of the spectrum (e.g. the starting value is 1.234um, I click the arrow, it goes to 2um), so I do not think I would ever use the arrows there.
  • It would be nice to have the live update when tabbing to the next entry. Could this be an option?
  • Said that, I do not find a big overhead in, for example, tabbing twice and then hitting return. I guess I need to try with different science cases, but a non-live update looks good to me (for now).

🐱

@pllim pllim added feature Feature request plugin Label for plugins common to multiple configurations labels Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request plugin Label for plugins common to multiple configurations
Projects
None yet
Development

No branches or pull requests

1 participant