Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad pixels from darks -- Input slope files #83

Open
bhilbert4 opened this issue Sep 10, 2019 · 3 comments
Open

Bad pixels from darks -- Input slope files #83

bhilbert4 opened this issue Sep 10, 2019 · 3 comments

Comments

@bhilbert4
Copy link
Collaborator

We should update the code such that it can use 0_ramp_fit or 1_ramp_fit files. This will make it easier for people who have exposures containing a single integration, where the pipeline (may not?) output a 1_ramp_fit file. I think the file format of the 0_ramp_fit and 1_ramp_fit files are the same. I think the only difference is the dimensionality of the data.

Perhaps it would be worth adding a check that the NINT header keyword is equal to 1 if the user attempts to use 0_ramp_fit files.

@KevinVolkSTScI and @bsunnquist made updates to the code to get it to work with their files. Are your updates generic enough that they can be applied to all instruments?

@KevinVolkSTScI
Copy link
Contributor

My code changes are not specific to an instrument. They should work for NIRSpec as well as for NIRISS. I will try to post the changes today or tomorrow morning, but I have other pressing issues right now so there is some chance it will take longer.

@bsunnquist
Copy link
Collaborator

Mine were specific to nircam, but all I had to do was change the filenames in a few places, so would be easy to generalize

@jemorrison
Copy link
Collaborator

My intention was if someone did not have 1_ramp.fits files it would by default look at 0_ramp.fits files.
I must of done something wrong. Bryan take a look at the module 'read_slope_integrations'
that is where I tried to do this. Maybe you can easily see what I did wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants