-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3593: 2nd group saturation part 2 #283
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
==========================================
+ Coverage 84.69% 84.74% +0.04%
==========================================
Files 44 44
Lines 8501 8527 +26
==========================================
+ Hits 7200 7226 +26
Misses 1301 1301 ☔ View full report in Codecov by Sentry. |
@tapastro Should now be ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks like a good algorithm to me. Thank you for making it handle ~arbitrary read patterns!
Running a set of regression tests on the PR pair here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1722/ |
Ready for review: this addresses JP-3593, flagging cosmic ray saturation in group 2 data in a consistent manner between both IRS2 and non-IRS2 modes using the new use_readpatt keyword. This PR is tied to JWST PR spacetelescope/jwst#8731
Checklist
CHANGES.rst
(either inBug Fixes
orChanges to API
)