-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use towncrier
to handle changelog entries
#284
use towncrier
to handle changelog entries
#284
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
==========================================
- Coverage 84.43% 84.38% -0.06%
==========================================
Files 41 41
Lines 7583 7557 -26
==========================================
- Hits 6403 6377 -26
Misses 1180 1180 ☔ View full report in Codecov by Sentry. |
**Checklist** | ||
|
||
- [ ] added entry in `CHANGES.rst` (either in `Bug Fixes` or `Changes to API`) | ||
- [ ] for a public change, added a towncrier news fragment in `changes/`: <details><summary>`echo "changed something" > changes/<PR#>.<changetype>.rst`</summary> | ||
|
||
- ``changes/<PR#>.apichange.rst``: change to public API | ||
- ``changes/<PR#>.bugfix.rst``: fixes an issue | ||
- ``changes/<PR#>.general.rst``: infrastructure or miscellaneous change | ||
- [ ] updated relevant tests | ||
- [ ] updated relevant documentation | ||
- [ ] updated relevant milestone(s) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checklist
-
for a public change, added a towncrier news fragment in
changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
changes/<PR#>.apichange.rst
: change to public APIchanges/<PR#>.bugfix.rst
: fixes an issuechanges/<PR#>.general.rst
: infrastructure or miscellaneous change
-
updated relevant tests
-
updated relevant documentation
-
updated relevant milestone(s)
ae18088
to
f637123
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
using
towncrier
to handle changelog entries willCHANGES.rst
we currently experience with PRsCHANGES.rst
consistent and eliminate duplicate sectionstowncrier
expects "news fragment" files (text files in thechanges/
directory with filenames in the format<PR#>.<changetype>.rst
, i.e. for this PR it would bechanges/284.general.rst
). See docs at https://towncrier.readthedocs.io/en/latest/tutorial.html#creating-news-fragmentswhen ready to make a release, run
towncrier build
to ingest the news fragments and generate a changelog section inCHANGES.rst
with all the new change log entries for that release (this clears thechanges/
directory of all news fragment files). This step should either be done before making a release, or could probably be added to a GitHub workflow triggered on release (to insert a commit and remake the tag).After merging this PR the
Release Process
wiki page will need to be updated to include a step to runtowncrier build
instead of manually editingCHANGES.rst
Checklist
CHANGES.rst
(either inBug Fixes
orChanges to API
)