Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calc_bias contains a missing import and is unused #296

Open
braingram opened this issue Oct 2, 2024 · 0 comments
Open

calc_bias contains a missing import and is unused #296

braingram opened this issue Oct 2, 2024 · 0 comments
Assignees

Comments

@braingram
Copy link
Collaborator

def calc_bias(self, countrates, sig, cvec, da=1e-7):

contains attempted uses of fit_ramps:

result_low_a = fit_ramps(z, self, sig, countrateguess=countrates)

which is undefined.

As we haven't seen any errors it's likely calc_bias is unused.

It's unclear to me if this is a bug (and it should be used) or if the test coverage is incomplete and we may see failures during non-test runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants