Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named Entities ending with s are being lemmatized #325

Closed
henningko opened this issue Apr 8, 2016 · 3 comments
Closed

Named Entities ending with s are being lemmatized #325

henningko opened this issue Apr 8, 2016 · 3 comments
Labels
bug Bugs and behaviour differing from documentation

Comments

@henningko
Copy link

Named entities ending with s will be treated by the lemmatizer as if they are plurals, e.g.
Bernie Sanders turns into bernie sander, ISIS becomes isi, United States becomes united state. It probably also applies to other suffixes.

This may be intentional, so maybe adding a flag would be a good solution. Or is there another work around?

[Update] Somewhat related: when something like CIA is at the end of a sentence, the named entity becomes CIA.. My guess is that this is done to account for acronyms like A.M., but the trend seems to be to eliminate periods from acronyms, so punctuation can probably be stripped from the Named Entity altogether (avoiding the inconsistency).

@honnibal honnibal added the bug Bugs and behaviour differing from documentation label Apr 11, 2016
@honnibal
Copy link
Member

Thanks for the report. Will add tests and fix.

honnibal added a commit that referenced this issue Apr 14, 2016
…n't receiving the PROPN tag, and personal pronouns weren't receiving the PRON tag. This should fix Issue #191, and also Issue #325, which reported that proper nouns were being lemmatized using the common noun policies. This lemmatization will be prevented if the universal tag is PROPN, not NOUN, as no lemmatization rules are loaded for the PROPN tag.
@honnibal
Copy link
Member

This should be fixed in the next release of the data. There are some details in the associated commit. Thanks again

@lock
Copy link

lock bot commented May 9, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bugs and behaviour differing from documentation
Projects
None yet
Development

No branches or pull requests

2 participants