Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README to reflect Elixir 1.10/1.11 child specs #27

Closed
aselder opened this issue Dec 1, 2020 · 1 comment · Fixed by #46
Closed

Update README to reflect Elixir 1.10/1.11 child specs #27

aselder opened this issue Dec 1, 2020 · 1 comment · Fixed by #46

Comments

@aselder
Copy link

aselder commented Dec 1, 2020

When following the README in Elixir 1.11, you get the following warning:

Compiling 11 files (.ex)
warning: Supervisor.Spec.worker/2 is deprecated. Use the new child specifications outlined in the Supervisor module instead
  lib/monitoring/application.ex:18: Monitoring.Application.start/2

We should update the README to use the new child spec style.
@aselder
Copy link
Author

aselder commented Dec 1, 2020

I'll open up a PR in the next couple of days

@GregMefford GregMefford mentioned this issue Nov 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update supervision tree docs in README spandex-project/spandex_datadog
1 participant
@aselder