Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put a license notice to each file #3796

Open
luixxiul opened this issue Nov 18, 2024 · 3 comments · May be fixed by #3859
Open

Put a license notice to each file #3796

luixxiul opened this issue Nov 18, 2024 · 3 comments · May be fixed by #3859
Labels
suggestion This issue is a feature request

Comments

@luixxiul
Copy link
Collaborator

Playbook Configuration: irrelevant

Matrix Server: irrelevant

Ansible: irrelevant

Problem description:
https://www.gnu.org/licenses/gpl-faq.en.html#NoticeInSourceFile says:

You should put a notice at the start of each source file, stating what license it carries, in order to avoid risk of the code's getting disconnected from its license. If your repository's README says that source file is under the GNU GPL, what happens if someone copies that file to another program? That other context may not show what the file's license is. It may appear to have some other license, or no license at all (which would make the code nonfree).

Adding a copyright notice and a license notice at the start of each source file is easy and makes such confusion unlikely.

I believe it would be appreciated by contributors if they are given a chance to add their names to the source code (regardless of the number of those who would like to do so actually), as I will.

Additional context
As an extensive contributor to https://github.com/element-hq/element-web/blame/develop/res/css/views/rooms/_EventTile.pcss (for styling of one of the most important components of Element Web), I regret that I have not pushed a request to put my name on it while I was working on it.

@luixxiul luixxiul added the question This issue is a question related to installation label Nov 18, 2024
@spantaleev
Copy link
Owner

A CREDITS file (like the Linux kernel's CREDITS file) may be another option for adding credits which does not pollute files with metadata.

It doesn't help with the "license being close to the source code file" though, so the other one may be useful as well (although at the cost of polluting files).

@luixxiul
Copy link
Collaborator Author

One of the reasons why putting a license notice to each file is worth doing looks to be that it should make it easier to transplant files to another repository like MASH. Some of the existing files in docs/ directory of this project could be re-used over there.

@luixxiul luixxiul added suggestion This issue is a feature request and removed question This issue is a question related to installation labels Nov 28, 2024
@luixxiul
Copy link
Collaborator Author

luixxiul commented Dec 7, 2024

@luixxiul luixxiul changed the title Put a license notice to each file? Put a license notice to each file Dec 7, 2024
@luixxiul luixxiul linked a pull request Dec 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion This issue is a feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants