fixes hard fault when calling smart config with wifi off #320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to this issue: https://github.com/spark/firmware/issues/310
Simply calling WiFi.on() after WiFi.disconnect() with
Start_Smart_Config()
ensures that callingWiFi.listen()
(which effectively calls:Start_Smart_Config()
) always runs without failing (Hard Fault SOS) under the following test set:Starting with the following 3 system modes:
SYSTEM_MODE(AUTOMATIC); // default behavior when no system mode is explicitly set
SYSTEM_MODE(MANUAL);
SYSTEM_MODE(SEMI_AUTOMATIC);
After calling:
Spark.connect();
Spark.disconnect();
WiFi.connect();
WiFi.disconnect();
WiFi.on();
WiFi.off();
We finally call:
WiFi.listen();
TEST APP