Feature/keys protocol #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m buffers, abstracting over the fact DFU requires a file.
… it is not specified, and the device supports multiple protocols. adds unit tests for the behaviour changes.
monkbroc
approved these changes
Feb 7, 2017
commands/KeyCommands.js
Outdated
| //backup their existing key so they don't lock themselves out. | ||
| function() { | ||
| var alg = self._getPrivateKeyAlgorithm() || 'rsa'; | ||
| var alg = self._getPrivateKeyAlgorithm() || defaultKeyAlgorithm; |
There was a problem hiding this comment.
defaultKeyAlgorithm is not defined anywhere.
|
There's also the failing Travis 💣 |
…since that method is guaranteed to return a value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #279 and #280 by reading the current protocol from the device when it is not specified, and the device supports multiple protocols.
Other changes:
particle keys protocoldisplays the currently configured protocol for a device