NTRIP Server restarted after going from Base to Rover

[PaulZC]

When in Rover mode, it should not be possible to start the connections to the NTRIP Servers. But I see the server being started when in Rover mode - after having been in Base.

Provide WiFi credentials.
Provide server details for one (or two) NTRIP servers.
Start the RTK in Temporary Base mode.
Allow the survey-in to complete. Firmware begins sending RTCM data to the servers.
Change to Rover mode.
The NTRIP server connections should be stopped, but I see them being periodically restarted - leading to WiFi badness when going into WiFi Config mode.

[PaulZC]

After a lot of digging and head-scratching, I eventually traced this to ntripServerRestart being called - instead of ntripServerStop. I believe calling ntripServerStop is the correct thing to do. ntripServerRestart actually turns the server on if the connection limit has not been reached... The same is true for ntripClientStop vs. ntripClientRestart.

@nseidle @LeeLeahy2 : please review this commit and let me know if you agree with the solution : af73bf3

[nseidle]

Looks good to me.

[nseidle]

Fixed in v4.1.