Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI for Learn More updates #1062

Open
kainjow opened this issue Apr 5, 2017 · 6 comments
Open

Improve UI for Learn More updates #1062

kainjow opened this issue Apr 5, 2017 · 6 comments

Comments

@kainjow
Copy link
Contributor

kainjow commented Apr 5, 2017

If an update uses a <link> Sparkle will show a Learn More button. However, it also shows "Would you like to download it now?" and "Release Notes" above the web view.

Maybe these should be configurable? It doesn't really makes sense if one is trying to show a marketing message, especially for paid upgrades.

@kornelski
Copy link
Member

Right, the message could be improved. However, it's supposed to be localized, so it might be tricky to make it configurable.

@kainjow
Copy link
Contributor Author

kainjow commented Apr 5, 2017

Maybe the appcast could be expanded for language support?

@kornelski
Copy link
Member

kornelski commented Apr 6, 2017

That would be relatively large effort for such a minor feature (hacking i18n in RSS, parsing it, changing internal feed representation, etc.)

OTOH I think I can simply change the UI string to drop the "Would you like to download it now?" bit.

@kainjow
Copy link
Contributor Author

kainjow commented Apr 6, 2017

hacking i18n in RSS

but I thought RSS was XML and thus extensible ;)

Maybe for a future version, the update window UI could be generated on the fly, based on certain parameters, instead of hacking the nib. Should be fairly easy with auto layout.

@kornelski
Copy link
Member

OK, hack maybe is an exaggeration. There's xml:lang and we could use a made-up element.

But if you want to make a sales pitch with a custom layout, we already support markup for this.

@kainjow
Copy link
Contributor Author

kainjow commented Apr 6, 2017

Yup html is already used for a pretty marketing message. Just think the other Sparkle text should be consistent if it's not an actual download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants