Enhancement: Add #key? #value? predicates to Node

[MatzFan]

Was gonna PR you this with (of course) tests, but couldn't figure out why my new methods were not found and the whole tmp folder builds thing. And then I read Y_U_NO_GEMSPEC.

Rationale:
Rubocop bugs me that instead of iterating a Nokogiri::XML::Node using .keys.include? or .values.include? I should be using hash #key? or #value? methods. As Node is a hash-like object I figured why not add them.

Code

def  keys?(key)
  keys.include? key
end

def value?(value)
  values.include? value
end

[flavorjones]

Hi! Thanks for opening this request.

FYI - you can create a temporary local gemspec for testing by running rake gem:spec (you'll need to make sure you've got the hoe-gemspec gem installed as well).

I'd accept a PR for this functionality. If you're unsure how to go about doing it, I'm happy to collaborate with you on it.

[knu]

I can think of how key? could be useful, but I'm not sure about value?.

[knu]

And I think we already have key?.

[MatzFan]

@knu - quite right, just #value? missing. Re a use case, it is quite possible what I was trying to do can be accomplished a better way with existing functionality - FWIW I was trying to find a node with a particular attribute value. Nevertheless, I just felt it may be good practice for hash-like objects to, as far as possible, replicate Ruby's Hash interface.

Thanks @flavorjones think I figured it out, PR on the way.

[flavorjones]

Will be in v1.11.0.