-
-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: switch to the ruby/setup-ruby action #2162
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@parndt Sweet! Thanks very much for showing us how to do this. Merging! |
@flavorjones you're very welcome; thanks for all the work on Nokogiri! Happy to have helped. 🎉 |
This was referenced Mar 5, 2021
Closed
This was referenced Mar 12, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
This switches the setup-ruby action to the one created by the
ruby organisation which has more
advanced features than the one already in use.
Most notably, this handles installing Bundler, bundling, and caching the
resulting bundle.
Have you included adequate test coverage?
Yes, which is to say it hasn't changed any code or tests, just how they
are run.
Does this change affect the behavior of either the C or the Java implementations?
No, just how CI runs, and you can see the results on this PR 😄.