[Feature request] Icon props to buttons

[guastallaigor]

What problem does this feature solve?

Possibility to insert icons inside the buttons, left or right of the text, or maybe sometimes just the icon itself, kind of like the Loaders Upload Button of Vuetify's example.

What is your proposed solution?

1.Passing a new prop, icon prepend/append and/or a new <slot name="icon">:

iconPrepend: String,
iconAppend: String

2.It can uses the <va-icon> component.

3.Can work with the icon named slot or by passing the props.

[damienix]

This idea is actually mentioned in Atlassian design :)
https://atlassian.design/guidelines/product/components/buttons

And it's also even implemented in React version of design as iconAfter and iconBefore
https://atlaskit.atlassian.com/packages/core/button

I think we just need to adjust the CSS to make something like this looke nicely

<va-button type="primary">
  <va-icon>edit</va-icon>
  Primary button
</va-button>

Let me check...

[damienix]

Ok, I think it will require tweaking the markup to properly handle margins but it wouldn't require any slots or attributes. Atlassian uses prop with a renderer in it so something between a prop and a slot.