Undefined variable in _generate_output_format

[stsievert]

I ran into an issue where latex_datatype wasn't defined in _generate_output_type when running a nbsphinx on a precomputed notebook.

This code appears to be untested; all code should be tested.

[mgeier]

Duplicate of #50?

Did you try the master branch?
This should be fixed with #51, which isn't in an official release yet.

This code appears to be untested; all code should be tested.

#51 also adds a section for this in the example notebooks, there are no tests other than that.

If you have an idea how to implement proper tests, I'd love to see a PR for that!

[stsievert]

Yes, duplicate.

Proper tests should test each function. Given specific inputs, the function
should produce specific outputs. Frameworks such as py.test and nose tests
are good for defining tests; any function named test_* is run.

[mgeier]

I know what tests are, but I didn't have the time or energy to implement proper automated tests yet and won't have in the foreseeable future. I'd be happy to get a PR, though.

In the meantime, the notebooks in the documentation serve as non-automated tests and they should cover most of the features. If there is something missing, again, I'm looking forward to PRs!

[mgeier]

I just made a new release (0.2.9), does it solve the issue?