-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error Page is not rendering CSS. #35
Comments
Please ignore this issue I was able to throw another exception and the beautiful error pages are now showing up as expected. |
same happening to me and its unfixable |
Yeah this is happening for me. It seems to show a non-styled Symfony error on view pages, but in a controller or in a route it shows the ignition error page. |
Are you using Clockwork, in you app as well? https://github.com/itsgoingd/clockwork |
No am using laravel debugbar |
I feel its an issue the previous ignition works well with no glitch |
I'm getting the same thing, I have clockwork installed but uninstalled it and the same thing occurs. Seems to only be with 500 errors as something less significant like an undefined variable shows ignition. Did a bit of debugging but unsure of expected behaviour. eg should ignition disable symfony/error-handler as they appear to do the same thing? Looks like symfony error-handler is getting in beforehand causing its output to get dumped in the script tag Started happening after upgrade from laravel 8 to 9 and changing When it's working it looks top-notch! :) |
Check if you really run PHP 8.1. That was my mistake. |
Yeah, 8.1.1
|
@jez500 have you check the version of PHP you're using for web requests? http://freek.dev/php-version |
Hi @freekmurze, I just doublechecked with phpinfo and definitely 8.1.1. I am using php:8.1.1-fpm-alpine3.15 image Requires from my composer.json if it helps:
|
For me, the html is malformed: <!DOCTYPE html>
<html lang="en" class="auto">
<!--
[stacktrace was here]
-->
<head>
<!-- Hide dumps asap -->
<style>
pre.sf-dump {
display: none !important;
}
</style>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta http-equiv="X-UA-Compatible" content="ie=edge">
<meta name="robots" content="noindex, nofollow">
<title>Undefined property: App\Models\UserGame::$score</title>
</head>
<body class="scrollbar-lg">
<script>
window.data = <!-- Undefined property: App\Models\UserGame::$score (500 Internal Server Error) -->
<!DOCTYPE html>
<html lang="en"> |
This exactly is what i feel is the cause it opens a new html tag in a previously opened one |
In the exceptions that I throw, the HTML of the Ignition page is valid. Could you create a minimal Laravel app where you recreate the issue? |
I wish I could. I've upgraded two projects to Laravel 9. One (with the most dependencies and complexity) is rendering fine, the other (much simpler) will not render. When starting a new project with the same |
Just doing some searching around, I think @jez500 was on to it:
It looks like Symfony's error handler HTML page is getting included in the output here. |
I think I found where the Symfony's error html page is included |
Hey all, a fix has been tagged here. Running |
Amazing, thank you so much for fixing this. Just checked out a random variable in my blade template and it is now showing the correct error page. |
Awesome, thank you! |
Hello there! I just updated a Laravel 8 application to Laravel 9. In my composer.json I updated:
"facade/ignition": "^2.5"
to"spatie/laravel-ignition": "^1.0"
I then ran
composer update
. In a sample route file: I manually threw an exception withthrow new \Exception('testing')
.The error page that get rendered shows the content but the CSS is not being loaded. I have included a image at the bottom.
Is there something I'm missing or an additional composer command I need to run?
Thank you for the assistance.
The text was updated successfully, but these errors were encountered: