Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for manipulations #3753

Open
jamieconnor opened this issue Dec 27, 2024 · 1 comment
Open

Update documentation for manipulations #3753

jamieconnor opened this issue Dec 27, 2024 · 1 comment

Comments

@jamieconnor
Copy link

Can we update the documentation for the manipulations page?

Now that Enums are being used from Spatie Image they are being used for manipulations differently. Just as a note this could be considered a breaking change for people upgrading.

Currently it is looking like this

$yourModel
   ->addMedia($pathToFile)
   ->withManipulations([
      '*' => ['orientation' => '90'],
      'thumb' => ['filter' => 'greyscale'],
   ]);

it should be this

$yourModel
   ->addMedia($pathToFile)
   ->withManipulations([
      '*' => ['orientation' => ['orientation' => '90']],
      'thumb' => ['greyscale' => []],
   ]);

I've got a PR for this, do I need to be a contributer to create a PR?

This relates to issue #3568

@freekmurze
Copy link
Member

Feel free to open a PR :thumbnail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants