DeferrableProvider causes config to not be loaded

[owenconti]

Hello, I believe this commit that introduced the DeferrableProvider is causing the non-published config file from being loaded: #660

This causes an issue in QueryBuilderRequest where all input data is returned instead of just the filter= values, because filterParameterName ends up being null: https://github.com/spatie/laravel-query-builder/blob/master/src/QueryBuilderRequest.php#L93

So far our fix is to just publish our own copy of the config file, but ideally users should not have to do that. I think using the DeferrableProvider may not be applicable for this package, since it does more than just register bindings: https://laravel.com/docs/8.x/providers#deferred-providers

Thanks for your time

[jonnywilliamson]

Just having the exact same issue. Unless I publish the config file, then the query builder breaks as it can't find the config values when trying to get the names for sort filter etc.

Thank you

[Quick fix is indeed to publish the config file, although in my case I don't really have any need to do so]

[AlexVanderbist]

Ah, that's not great. Thanks for bringing this to our attention. Looks like it slipped past the tests because of the way Testbench is set up...

Tagged a fix in 4.0.1

[jonnywilliamson]

Amazing response time!

Reported and fixed and new release inside 6 minutes! Insane! 😆

Thank you.