Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make failed immediately #46

Open
cmfeng opened this issue Oct 15, 2024 · 2 comments
Open

make failed immediately #46

cmfeng opened this issue Oct 15, 2024 · 2 comments

Comments

@cmfeng
Copy link

cmfeng commented Oct 15, 2024

After cloning the repo, make all failed with the following error

make all
=== building spdkcsi binary
=== running golangci-lint
e2e/utils.go:389:2: undefined: Expect (typecheck)
        Expect(err).ShouldNot(HaveOccurred())
        ^
e2e/utils.go:397:2: undefined: Expect (typecheck)
        Expect(podList.Items).NotTo(BeNil())
        ^
e2e/utils.go:398:2: undefined: Expect (typecheck)
        Expect(err).ShouldNot(HaveOccurred())
        ^

Here's go version on my gLinux

go version
go version go1.23-20240626-RC01 cl/646990413 +5a18e79687 X:fieldtrack,boringcrypto linux/amd64

Could this be caused by the project not working with higher Go version? Or any idea on possible causes? Thanks!

@cyb70289
Copy link
Contributor

This is golangci-lint error. Guess it enforces more strict checking in newer version.
You can comment the "lint" target in Makefile as a quick workaround. spdkcsi image should have been built successfully.

@cmfeng
Copy link
Author

cmfeng commented Oct 15, 2024

You're right, the make image does succeed, and I do see the built image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants