Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show regexp in HTML output for replacable text #17

Closed
goneall opened this issue Apr 9, 2018 · 7 comments
Closed

Show regexp in HTML output for replacable text #17

goneall opened this issue Apr 9, 2018 · 7 comments

Comments

@goneall
Copy link
Member

goneall commented Apr 9, 2018

Submitted by @wking and moved from spdx/tools#120

formatReplaceabledHTML currently sets class="replacable-license-text". I think we should also set title="match-regexp" or something so users can mouse over (if they have a mouse) to see the replacement regexp. Raw regexps aren't the greatest UX, but that's what we've been using so far, and I can't think of anything better.

Spun off from here.

@goneall
Copy link
Member Author

goneall commented Apr 9, 2018

@wking any thoughts on how to handle the empty "original text" case?

This may be a separate issue, but currently there is no hint at all that there is variable text if the original is left out or blank.

@jlovejoy Any thoughts on including a mouse over for the var text to describe the var using a regular expression?

@goneall
Copy link
Member Author

goneall commented Apr 9, 2018

Please refer to the original closed issue for the entire conversation: spdx/tools#120

From @wking

I've mocked something up at 1, which is primarily using CSS with a
placeholder wherever you want the icon. That ensures the icon
is not going to be copy/pasted from a rendering of the HTML. I've
used ☿ for the icon, but I didn't hunt around too hard. Anything that
gets “this might change” across and won't be mistaken for the license
text itself would work.

@wking
Copy link
Contributor

wking commented Apr 10, 2018 via email

@goneall
Copy link
Member Author

goneall commented Apr 10, 2018

I'm going to wait one more release of the license list (version 3.2) to give @jlovejoy a chance to review and comment on the UI

@goneall
Copy link
Member Author

goneall commented Sep 5, 2021

I haven't heard from @jlovejoy on this, so I'm closing the issue.

@goneall goneall closed this as completed Sep 5, 2021
@jlovejoy
Copy link
Member

sorry @goneall - this is old and re-reading it now, I'm not even sure what it was proposing!

@goneall
Copy link
Member Author

goneall commented Sep 11, 2021

sorry @goneall - this is old and re-reading it now, I'm not even sure what it was proposing!

No worries - it was proposing we add a feather where you click or hover over the replaceable text and it will show you the regular expression. I think there was only one person requesting the feature, so we should be fine just closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants