Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to document errata #598

Closed
jlovejoy opened this issue Jan 11, 2018 · 10 comments
Closed

how to document errata #598

jlovejoy opened this issue Jan 11, 2018 · 10 comments

Comments

@jlovejoy
Copy link
Member

inspired by this PR and error :( #589
question/issue is: should we have a way to document major things like this (major as in, this scenario impacted the actual text of the license; there may be other small, minor updates we do that are not necessary to track) via a errata for releases, in release notes, ??

@jlovejoy
Copy link
Member Author

(aim to discuss on call)

@wking
Copy link
Contributor

wking commented Jan 11, 2018 via email

@wking
Copy link
Contributor

wking commented Mar 26, 2018

Do we want to resolve this before we cut 3.1?

@bradleeedmondson
Copy link
Contributor

Going to have to wait; we want to get the new licenses added and will return to this for 3.2 or later

@jlovejoy jlovejoy added this to the Later Release milestone Oct 26, 2018
@swinslow
Copy link
Member

swinslow commented Nov 2, 2018

I'd lean mildly (not strongly) towards a lightweight approach here.

Something like noting errata changes in the release notes for a new release, and perhaps also in the "Notes" section of that license's entry on the license list.

With license list development occurring on GitHub, anyone is able to see the details of any (rare, but occasional) evolution of license texts, by looking directly in the license-list-XML repo. Between that and a note on the license's entry briefly describing an errata fix, I wouldn't want something heavier-weight that might slow down momentum.

@swinslow
Copy link
Member

swinslow commented Dec 9, 2021

Now that we're regularly publishing release notes as part of each release (and aggregating them in the repo), I'd say that's perhaps the best place to document errata.

The main way I'd suggest to handle this would be to create an "errata" tag in GitHub, and if we have an issue / PR that is fixing an actual error in a previously-published license, then the PR should get tagged as "errata". If that happens, then when I'm creating the release notes at the end of the release, I'll see it when I review all the issues and PRs from that release cycle, and I can explicitly call it out in an "Errata:" section of the release notes.

I assume this would only be for actual errors in prior licenses that are being fixed, and not e.g. improvements to markup, etc.

@jlovejoy
Copy link
Member Author

jlovejoy commented Dec 9, 2021

I like this solution, @swinslow - especially since this issue was raised before we did release notes. Luckily, we've only had a few issues like this in 12 years, so something easy and lightweight, like a tag, note in release notes, and note in Note field as needed is perfect to cover all bases.

@jlovejoy
Copy link
Member Author

jlovejoy commented Dec 9, 2021

@swinslow - created "errata" label - I think you meant label, not tag
confirm if correct and close?!

@seabass-labrax
Copy link
Contributor

Yup, sounds good to me :)

@swinslow
Copy link
Member

swinslow commented Dec 9, 2021

Yup! "Label" is apparently what I meant in GitHub-speak :)

LGTM, I'm closing this, thanks all!

@swinslow swinslow closed this as completed Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants