Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make "Package CONTAINS Package" valid even when files_analyzed == False #732

Closed
armintaenzertng opened this issue Jul 19, 2023 · 0 comments · Fixed by #733
Closed

make "Package CONTAINS Package" valid even when files_analyzed == False #732

armintaenzertng opened this issue Jul 19, 2023 · 0 comments · Fixed by #733

Comments

@armintaenzertng
Copy link
Collaborator

So far we assumed that all CONTAINS relationships point from a Package to a File. However, this is not specified by the spec, so a "Package CONTAINS Package" is also possible. This currently invalidates if files_analyzed is set to False for the first Package. This should be adapted to only invalidate in the "Package CONTAINS File" case.

Note that the relationship can also point to an SPDX element from an external document, in which case we can not determine whether the element is a File or Package or Snippet. In this case we have to assume that it is valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant