-
-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how to install prerequisites in examples READMEs #1993
base: main
Are you sure you want to change the base?
Conversation
Please review this draft, if you like this approach I will extend to other README.rst files. If it's not obvious, I'm trying to figure out how to work with you all. Baby steps :) |
Thanks @chrisinmtown, this looks good to me. Would be great to extend it to the other examples. |
I am extending the changes to all the examples. Please check example
Do you have time for this? |
180f06a
to
0642103
Compare
Let's leave that example as is for now then. Would be great if you could add a notice that it is outdated to the README. For the other examples, the |
I will ask the cloud a few questions and see if I can figure it out :)
I see that Flask is not needed for |
16effac
to
37e84aa
Compare
This PR has primarily documentation changes. I tweaked one API spec and one requirements file to make the examples work. Please consider. |
Add server url /openapi to JWT example Add TODO to SQLAlchemy example, does not work with current versions Correct name of module in v3 instructions Fixes spec-first#1948, spec-first#1987
37e84aa
to
cab9f86
Compare
Would you please give me an opinion here? It's a real challenge to contribute when people go silent for a full week at a time. |
Add server url /openapi to JWT example
Add TODO to SQLAlchemy example, does not work with current versions
Correct name of module in v3 instructions
Fixes #1948, #1987