Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FlaskApp number of threads configurable #1979

Open
nmoreaud opened this issue Sep 27, 2024 · 2 comments
Open

Make FlaskApp number of threads configurable #1979

nmoreaud opened this issue Sep 27, 2024 · 2 comments
Labels
enhancement PR welcome We would welcome and review a PR addressing this issue

Comments

@nmoreaud
Copy link

Hello

We are migrating a Connexion v2 application to Connexion v3.
We are trying to use FlaskApp, however we encounter bugs in our services due to the number "worker threads" (10 WSGI threads) which is no longer configurable.
I guess the long term solution will be to drop Flask dependency in our software, but for now we'd like to make it work with the backward compatibility layer.
Can you please make the number of worker threads configurable?

https://github.com/spec-first/connexion/blob/main/connexion/apps/flask.py#L133
https://github.com/abersheeran/a2wsgi/blob/master/a2wsgi/wsgi.py#L157
https://connexion.readthedocs.io/en/latest/v3.html#running-the-application

Additional info:

Output of the commands:

Python 3.11.10
connexion==3.1.0

@nmoreaud
Copy link
Author

nmoreaud commented Oct 1, 2024

Do you plan to do this? Otherwise I'll have to monkey patch it.

@RobbeSneyders
Copy link
Member

I would welcome a PR with this change.

Permalink to the correct line.

@RobbeSneyders RobbeSneyders added enhancement PR welcome We would welcome and review a PR addressing this issue labels Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement PR welcome We would welcome and review a PR addressing this issue
Projects
None yet
Development

No branches or pull requests

2 participants