Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking-vector image should be marked darkmode-aware #2905

Closed
Kaiido opened this issue Aug 6, 2024 · 1 comment
Closed

Tracking-vector image should be marked darkmode-aware #2905

Kaiido opened this issue Aug 6, 2024 · 1 comment

Comments

@Kaiido
Copy link

Kaiido commented Aug 6, 2024

In whatwg/whatwg.org#444 the tracking-vector svg from whatwg has been made darkmode-aware, however for it to render properly without a white background, it needs a class="darkmode-aware".

Looking at the source it seems there is an inline fallback that is not darkmode-aware. It also seems that every consumer could define their own source for the image file? That would probably make things harder to fix.

@tabatkins
Copy link
Collaborator

Ooh, thanks for pointing this out. I've gone ahead and made my inline image darkmode-aware, and added the class to the generated img. I've noted in the docs that the external image (if provided) must be darkmode-aware as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants