Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Macro's are not replaced everywhere in Bikeshed 4 #2974

Open
vdboor opened this issue Dec 2, 2024 · 1 comment
Open

Text Macro's are not replaced everywhere in Bikeshed 4 #2974

vdboor opened this issue Dec 2, 2024 · 1 comment

Comments

@vdboor
Copy link

vdboor commented Dec 2, 2024

Since Bikeshed 4, the functionality of text macro's is diminished. It's no longer possible to include a macro in CSS <style> elements, or use them as literal-text replacement inside html tags.

Here is an example that renders differently in Bikeshed 4:

<pre class='metadata'>
Title: Test
Shortname: test
Status: LS
Abstract: test
Text Macro: INLINEATTR style="background-color: #450022;"
</pre>

Hallo [TITLE]

<div title="[TITLE]">Tooltip test</div>

<div [INLINEATTR]>background test fails</div>

<style type="text/css">
    #toc::before {
        content: "Macro fails: [TITLE]";
    }
</style>

On a related note, running Bikeshed 3 needs the --no-update note, as it can no longer find its data files.

@tabatkins
Copy link
Collaborator

Ah, losing macros in styles/scripts was an accident, I think. I can turn that back on.

I was really hoping nobody was using macros for tag contents, so I didn't have to implement it. I can do so, tho, so long as it's okay for it to still be whole constructs (like, entire attributes), which it looks like it is in your above example. (Doing arbitrary substitution would be a lot more annoying.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants