Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [intert] attr to #root when in modal #2618

Closed
maxpatiiuk opened this issue Dec 13, 2022 · 1 comment · Fixed by #3264
Closed

Add [intert] attr to #root when in modal #2618

maxpatiiuk opened this issue Dec 13, 2022 · 1 comment · Fixed by #3264
Assignees
Labels
1 - Request A request made by a member of the community

Comments

@maxpatiiuk
Copy link
Member

New HTML attribute has been added for modal dialogs:

https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/inert

It should be added to the #root element when in modal dialog.

Besides the improvements for screen readers, it would also reduce the need for focus management and (in some browsers), make Cmd+F ignore the content behind the dialog

@specifysoftware
Copy link

This issue has been mentioned on Specify Community Forum. There might be relevant details there:

https://discourse.specifysoftware.org/t/specify-7-8-12-release-announcement/1202/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Request A request made by a member of the community
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants