Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed merge gets 'old_model_id' response, no error available for the user #3857

Closed
bronwyncombs opened this issue Jul 27, 2023 · 2 comments · Fixed by #3866
Closed

Failed merge gets 'old_model_id' response, no error available for the user #3857

bronwyncombs opened this issue Jul 27, 2023 · 2 comments · Fixed by #3866
Assignees
Labels
1 - Bug Incorrect behavior of the product 2 - Merging
Milestone

Comments

@bronwyncombs
Copy link

Followed testing instructions from this comment

Got this error when failed in v7.9-dev

{
  "messageId": 499,
  "read": false,
  "timestamp": "2023-07-27T20:36:01",
  "type": "record-merge-failed",
  "payload": {
    "response": "local variable 'old_model_id' referenced before assignment",
    "task_id": "a759aced-be89-4c08-9393-35d888347a8a",
    "table": "Agent",
    "new_record_id": 2317,
    "old_record_ids": "[]",
    "new_record_data": "{\"id\": 2317, \"abbreviation\": null, \"agenttype\": 0, \"date1\": null, \"date1precision\": null, \"date2\": null, \"date2precision\": null, \"dateofbirth\": null, \"dateofbirthprecision\": null, \"dateofdeath\": null, \"dateofdeathprecision\": null, \"datetype\": null, \"email\": null, \"firstname\": null, \"guid\": \"ccf2da26-7f5f-4d7e-9b49-947fff423a21\", \"initials\": null, \"integer1\": null, \"integer2\": null, \"interests\": null, \"jobtitle\": null, \"lastname\": \"2\", \"middleinitial\": null, \"remarks\": null, \"suffix\": null, \"text1\": null, \"text2\": null, \"text3\": null, \"text4\": null, \"text5\": null, \"timestampcreated\": \"2023-07-27T20:27:25\", \"timestampmodified\": \"2023-07-27T20:30:44\", \"title\": null, \"url\": null, \"verbatimdate1\": null, \"verbatimdate2\": null, \"version\": 1, \"collcontentcontact\": null, \"colltechcontact\": null, \"createdbyagent\": \"/api/specify/agent/1313/\", \"division\": \"/api/specify/division/2/\", \"instcontentcontact\": null, \"insttechcontact\": null, \"modifiedbyagent\": \"/api/specify/agent/1313/\", \"organization\": null, \"specifyuser\": null, \"orgmembers\": \"/api/specify/agent/?organization=2317\", \"collectors\": \"/api/specify/collector/?agent=2317\", \"members\": \"/api/specify/groupperson/?member=2317\", \"resource_uri\": \"/api/specify/agent/2317/\", \"catalogerof\": \"/api/specify/CollectionObject?cataloger=2317\", \"addresses\": [], \"agentattachments\": [], \"agentgeographies\": [], \"agentspecialties\": [], \"variants\": [], \"groups\": []}"
  }
}


@bronwyncombs bronwyncombs added the 1 - Bug Incorrect behavior of the product label Jul 27, 2023
@acwhite211 acwhite211 self-assigned this Jul 27, 2023
@acwhite211 acwhite211 added this to the 7.9 milestone Jul 27, 2023
@github-project-automation github-project-automation bot moved this to 📋Back Log in General Tester Board Jul 27, 2023
@bronwyncombs
Copy link
Author

SELU_2_3_23: no response message for failed merge

Screenshot 2023-07-27 at 8 29 55 PM

@grantfitzsimmons grantfitzsimmons changed the title Failed merge gets 'old_model_id' response Failed merge gets 'old_model_id' response, no error available for the user Jul 28, 2023
@acwhite211
Copy link
Member

acwhite211 commented Jul 28, 2023

The error "local variable 'old_model_id' referenced before assignment" seems to be do to the old_record_ids = []. I will create a PR that will catch this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Bug Incorrect behavior of the product 2 - Merging
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants