Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert js to ts files #4573

Closed
CarolineDenis opened this issue Feb 21, 2024 · 1 comment
Closed

Convert js to ts files #4573

CarolineDenis opened this issue Feb 21, 2024 · 1 comment
Labels
1 - Request A request made by a member of the community res:duplicate Duplicate of an existing issue

Comments

@CarolineDenis
Copy link
Contributor

CarolineDenis commented Feb 21, 2024

From @maxpatiiuk in #4558 (comment):

After spending several hours trying to resolve the build issues from https://github.com/specify/specify7/actions/runs/7963889013/job/21740345853, I got these results:

As a workaround for privatenumber/tsx#38, converted .js files to .ts
But also, it's time for those to be TypeScript
Note, I added // @ts-nocheck to the top of the files to suppress
TypeScript errors for now, but this should be removed once we move way from Backbone
Refactored our configs to use ESM over Common JS because I wasn't able to get swc-node to work.
tsx however works fine when using "type": "module" in package.json.
And it's about time to convert to ESM anyway - while there would still be some friction expected, going forward, there > would be more friction from not using ESM than using ESM
Fix issues with Leaflet in node.js. See commit comment in 342a727

@CarolineDenis CarolineDenis added the 1 - Request A request made by a member of the community label Feb 21, 2024
@maxpatiiuk
Copy link
Member

This issue is redundant with #4286

@maxpatiiuk maxpatiiuk closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2024
@maxpatiiuk maxpatiiuk added the res:duplicate Duplicate of an existing issue label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Request A request made by a member of the community res:duplicate Duplicate of an existing issue
Projects
None yet
Development

No branches or pull requests

2 participants