Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI add build job on mac (windows?) #270

Closed
Yuval-Ariel opened this issue Nov 24, 2022 · 1 comment · Fixed by #432
Closed

CI add build job on mac (windows?) #270

Yuval-Ariel opened this issue Nov 24, 2022 · 1 comment · Fixed by #432
Assignees
@maxb-io
Labels
ci

Comments

@Yuval-Ariel
Copy link
Contributor

Owner:

Is your feature request related to a problem? Please describe.
current sanity build jobs in the CI dont cover MAC platform. there was a compile error which should have been caught by the CI:

tools/db_bench_tool.cc:6835:26: error: implicit conversion loses integer precision: 'XXH64_hash_t' (aka 'unsigned long long') to 'unsigned int' [-Werror,-Wshorten-64-to-32]
    unsigned int xxh64 = XXH64(str.data(), str.length(), 0);
@Guyme Guyme added the ci label Jan 18, 2023
@speedbadmin
Copy link
Contributor

deployed a new runner for MacOS

@maxb-io maxb-io linked a pull request Mar 19, 2023 that will close this issue
added ci_macos.yml file for automation of tests and builds on MacOS #432
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxb-io maxb-io

Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added ci_macos.yml file for automation of tests and builds on MacOS speedb-io/speedb
4 participants
@maxb-io @Yuval-Ariel @speedbadmin @Guyme