Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Testing:Test paired bloom filter as part of db_bloom_filter_test and remove speedb_db_bloom_filter_test suite #809

Closed
udi-speedb opened this issue Jan 15, 2024 · 0 comments · Fixed by #810
Assignees
Labels
enhancement New feature or request tests Working on it A feature request that is being actively worked on

Comments

@udi-speedb
Copy link
Contributor

udi-speedb commented Jan 15, 2024

The paired bloom filter is a plugin module. here is an existing bloom filter test suite called db_bloom_filter_test.cc
To test the paired bloom filter, instead of adding the paired bloom filter as another type of filter that will be tested by db_bloom_filter_test.cc, that file was duplicated in the plugin folder (plugin/speedb/paired_filter), and tests only the paired bloom filter.
The drawbacks are:

  • Duplication of a lot of code.
  • The need to update speedb_db_bloom_filter_test.cc whenever db_bloom_filter_test.cc changes.

As part of the rebase on RocksDB 8.6.7, db_bloom_filter_test.cc has undergone significant changes. The corresponding changes were NOT made on speedb_db_bloom_filter_test.cc and it was disabled.

A much better alternative would be to support the testing of the paired bloom filter within db_bloom_filter_test.cc, as another type of filter. The paired bloom filter may still remain a plugin module, and may be created using the "CreateFromString()" capability, as is done, for example, in db_bench.

@udi-speedb udi-speedb self-assigned this Jan 16, 2024
@udi-speedb udi-speedb added enhancement New feature or request tests Working on it A feature request that is being actively worked on labels Jan 16, 2024
@udi-speedb udi-speedb moved this to 🏗️ Working on it in Speedb Roadmap Jan 16, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ Working on it to 📖 Need your Opinion! in Speedb Roadmap Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests Working on it A feature request that is being actively worked on
Projects
Status: 📖 Need your Opinion!
Development

Successfully merging a pull request may close this issue.

1 participant