Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unused variable warnings in db_bench_tool.cc #671

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Fix unused variable warnings in db_bench_tool.cc #671

merged 1 commit into from
Sep 18, 2023

Conversation

git-hulk
Copy link
Contributor

@git-hulk git-hulk commented Sep 7, 2023

num_seek_to_first and num_next are not used in db_bench_tool. It will throw warnings and then fail to build.

/Users/hulk/code/cxx/speedb/tools/db_bench_tool.cc:7693:14: error: variable 'num_seek_to_first' set but not used [-Werror,-Wunused-but-set-variable]
    uint64_t num_seek_to_first = 0;
             ^
/Users/hulk/code/cxx/speedb/tools/db_bench_tool.cc:7694:14: error: variable 'num_next' set but not used [-Werror,-Wunused-but-set-variable]
    uint64_t num_next = 0;

@Guyme Guyme requested a review from Yuval-Ariel September 18, 2023 12:18
Yuval-Ariel
Yuval-Ariel approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@Yuval-Ariel Yuval-Ariel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks a lot!

@Yuval-Ariel Yuval-Ariel merged commit 19ad8a8 into speedb-io:main Sep 18, 2023
4 of 5 checks passed
udi-speedb pushed a commit that referenced this pull request Nov 23, 2023
@git-hulk @udi-speedb
Build: Fix unused variable warnings in db_bench_tool.cc (#671)
46fdccf
udi-speedb pushed a commit that referenced this pull request Dec 6, 2023
@git-hulk @udi-speedb
Build: Fix unused variable warnings in db_bench_tool.cc (#671)
4650348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuval-Ariel Yuval-Ariel Yuval-Ariel approved these changes

Assignees

@Yuval-Ariel Yuval-Ariel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@git-hulk @Yuval-Ariel