Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.1.2 announcement emails #127

Closed
7 tasks done
spencerahill opened this issue Jan 26, 2017 · 17 comments
Closed
7 tasks done

v0.1.2 announcement emails #127

spencerahill opened this issue Jan 26, 2017 · 17 comments

Comments

@spencerahill
Copy link
Owner

spencerahill commented Jan 26, 2017

Once we've got v0.1 available via conda-forge (see #112), we should make an announcement in as many places as we can. Below are the ones that come to mind for me. @spencerkclark any others?

  • pangeo mailing list
  • xarray mailing list
  • pyaos mailing list
  • Princteon AOS mailing lists
  • GFDL python mailing list
  • My twitter (@spencerahill)
  • climlist
@spencerkclark
Copy link
Collaborator

Does v0.1 ship with the code pre-#126? As small as the changes are, without them the code is pretty broken for any calculations involving pressure (symptomatic of our lack of test coverage there...).

I'm in the process of updating some of my object library and doing some calculations with the latest version (that's how I noticed the issues fixed in #126). Do you think it might be worth holding off a few more days in case more bugs like this surface (and releasing an intermediate version with the bug fixes)?

@spencerkclark
Copy link
Collaborator

I'm sorry about this; the issues in #126 stem completely from my refactoring of __config__ and internal_names in #90.

@spencerahill
Copy link
Owner Author

Does v0.1 ship with the code pre-#126

Do you think it might be worth holding off a few more days in case more bugs like this surface (and releasing an intermediate version with the bug fixes)?

Yes and yes. So this will go into v0.1.1. It has to be a formal PyPI and Github release to go on conda-forge.

No worries! It happens, and that's on us collectively since we don't have sufficient tests in place to catch it. Plus it was my suggestion to do internal_names, AND I missed it when I did the code review of your PR.

How hard will it be to write a unit test for this? Were we premature in closing #22? I would really like to get a test in that catches this. We'll also need to add a what's new entry.

@spencerahill spencerahill changed the title v0.1 announcement emails v0.1.1 announcement emails Jan 31, 2017
@spencerkclark
Copy link
Collaborator

@spencerahill once we merge #135, give me another chance to run some real calculations (maybe it would be good if you did as well) just to be absolutely sure there are no more glaring bugs. Then we can go ahead with the announcement emails.

@spencerahill
Copy link
Owner Author

Yes, will do also. Let's play with it through the end of this week; if no further critical problems are found then I'll submit to PyPI and conda-forge over the weekend or next week. Will wait to do the announcements until we're uploaded to conda-forge.

@spencerahill
Copy link
Owner Author

I'll also take care of #124 before then; that's the last remaining blocker for v0.1.1

@spencerahill
Copy link
Owner Author

Waiting on the conda-forge CI to finish; once that is finished, will update the docs and the README "quickstart" to reflect that conda is the preferred installation method. THEN we're ready to announce.

@spencerahill
Copy link
Owner Author

The conda-forge build worked as hoped. However, the RTD builds problem is giving me pause. I don't want our first advertised release to have out-of-date documentation. So I think it's worth waiting until that's fixed.

Can also try to find a workaround if the RTD folks don't make some progress on it soon.

@spencerahill
Copy link
Owner Author

Fortunately RTD appears to be in the process of resolving this: readthedocs/readthedocs.org#2651 (comment)

@spencerahill
Copy link
Owner Author

RTD fixed the problem, and doc builds are succeeding again. So I will proceed with #147 and then the quickstart update and then finally we can roll out the announcements.

@spencerahill spencerahill changed the title v0.1.1 announcement emails v0.1.2 announcement emails Mar 8, 2017
@spencerahill spencerahill added this to the v0.1.2 milestone Mar 8, 2017
@spencerahill
Copy link
Owner Author

spencerahill commented Mar 8, 2017

@spencerkclark let me know if you think I'm just getting cold feet, but I think we need one more iteration before blasting to the world, i.e. a v0.1.2 release.

Motivation: the main script is the primary way we intend for users to interface with aospy, yet there are several problems with it:

I feel that putting all of these in place would make the package much more enticing to new users.

Given the blog post that we have due by the end of the month, this still needs to get done pretty soon; I fully intend to have it released on PyPI and submitted to conda by the end of next week, leaving us two weeks with the package feature-locked during which to write the post.

Does this seem reasonable to you? I am happy to do all of this; I think much of it will be pretty simple now that I've typed this all out.

@spencerkclark
Copy link
Collaborator

By all means -- I think #149 and #152 alone could be thought of as blockers. It would be a major plus to improve the documentation / examples on how the current two users typically use aospy (#150 and #151), so I am all for doing this!

@spencerahill
Copy link
Owner Author

Ok cool. Thanks for your feedback. Will put together 1 or more PRs in the coming days.

@spencerahill
Copy link
Owner Author

@spencerkclark do you feel like we're good for the v0.1.2 release once #166 is done? All other v0.1.2 items are done.

For the sake of the blogpost, probably should release either tomorrow (Thursday) or Friday

@spencerahill
Copy link
Owner Author

@spencerkclark Barring any objections, will do the v0.1.2 release later tonight.

@spencerkclark
Copy link
Collaborator

I agree; I think things are ready to go.

@spencerahill
Copy link
Owner Author

It is done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants